E-mails sent and received no longer parses Danish characters correctly

mbp's Avatar


22 Jun, 2009 09:55 AM

I don't know if you did an update recently, but suddenly all e-mail received and sent by Tender App no longer represent Danish characters such as æ, ø, å correctly. They appear as æ, ø and å respectively

  1. 1 Posted by cstepanyk on 22 Jun, 2009 01:55 PM

    cstepanyk's Avatar

    Same for French. IMHO it's an encoding problem...

  2. 2 Posted by Kyle Neath (Git... on 22 Jun, 2009 08:58 PM

    Kyle Neath (GitHub Staff) 's Avatar

    Thanks for the heads up, we're taking a look at this right now.

  3. 3 Posted by rick on 22 Jun, 2009 09:04 PM

    rick's Avatar

    Did this just happen over the weekend? We didn't change anything with the email parsing that I know of... Can one of you send us a link to a discussion that is exhibiting this behavior, and possibly one that works fine?

  4. 4 Posted by rick on 22 Jun, 2009 09:05 PM

    rick's Avatar

    Actually disregard, Kyle found an example for me :)

  5. 5 Posted by mbp on 22 Jun, 2009 09:13 PM

    mbp's Avatar

    Yes, it must have happened over the weekend, since it appeared on the first tender issue that we received Monday morning (we don't receive in the weekends, but we receive all weekdays).

    I can link some examples to you still need, but I would prefer not linking to my companys private discussions in a public forum.

  6. 6 Posted by mbp on 22 Jun, 2009 09:16 PM

    mbp's Avatar

    By the way, it seems to be more than just an e-mail problem, I now see in my original post (entered via web) that the Danish characters are wrongly encoded. (Here, I try again: æ, ø, å)

  7. 7 Posted by mbp on 22 Jun, 2009 09:17 PM

    mbp's Avatar

    This time it worked. Appears pretty random, or maybe you fixed it.

  8. 8 Posted by rick on 22 Jun, 2009 09:17 PM

    rick's Avatar

    Okay, I found the issue. I don't think we were doing anything special for unicode characters before. However, I changed how comment bodies are stored over the weekend, and I guess something in that converts the unicode characters to the \unnn characters. I'm going to add some code that handles this early on and converts those to HTML entities instead. That should work much better.

  9. 9 Posted by mbp on 22 Jun, 2009 09:19 PM

    mbp's Avatar

    The character set for Tender App is UTF-8, there is no need to convert them to entities, or anything else, for that matter...

  10. 10 Posted by rick on 22 Jun, 2009 09:19 PM

    rick's Avatar

    mdp: no, Markdown converted those characters to html entities I think. Incoming emails are shown without markdown parsing by default.

  11. 11 Posted by rick on 22 Jun, 2009 11:05 PM

    rick's Avatar

    Hey guys, I have a fix for this. All your existing discussions should
    work once I deploy tonight without any maintenance on my part. We're
    going to kick the tires on staging a bit to make sure.

  12. 12 Posted by rick on 22 Jun, 2009 11:50 PM

    rick's Avatar

    Okay it's fixed now. The comment bodies are going through a json parser that happens to convert unicode characters to the \u strings. It was an unintended effect, but I've got the fix in place that converts those references back.

  13. rick closed this discussion on 22 Jun, 2009 11:50 PM.

Discussions are closed to public comments.
If you need help with Tender please start a new discussion.

Keyboard shortcuts


? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac